Overall repository cleanup #5
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: asagiri/asagiri#5
Loading…
x
Reference in New Issue
Block a user
No description provided.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
This is entirely on me, I'll do it.
As said in #11 we should modularize code and stop repeating it in folders. One such example of this is that there is an implementation of strlen in arch/aarch64 which should ideally be imported from libc.
This is almost completely done, only thing I now see are the compile-toolchain script and the Makefile only targetting aarch64 (RPi3 to be exact), the aarch64 linker script being aligned by 4K only, hardcoded offsets in arch/aarch64/uart.c and the presence of the u-boot folder.
fixed all warnings with
2107ea43ffbesides mmio_read and mmio_writeFixed all the remaining warnings including the linker ones. All that remains are some hard coded values.
-pedantic will introduce more warnings, @FMudanyali :)
Can we also deduplicate the logic between toolchain make include files? CFLAGS and LDFLAGS in general are kinda dirty right now.
done with #22, I went ahead and also added -Wshadow and -Wstrict-aliasing.
On another note, first I tried C89 and changed all // comments with /**/, then later realized C89 does not support variable sized arrays and that is really not good, but i also didn't want to revert changes on comments so I may have declared the usage of /**/ for all comments in the projects' coding convention.
tbh it looks nicer that way...
... ...😭
Integrated clang-format with custom config in
722d59a3e0Added a git hook and script to deploy it in
b96da58defThe hook will run
git clang-formatbefore commit, which will lint current changes before commit.After a very throughout peer review of clang-format settings with @sateallia, we have decided to change alignment options with commit
7f0a207220, it should be noted that even the slightest change in the linter configuration changes all the files in the repository. It is advised to not touch it unless absolutely necessary.I say this and still change things. Apparently with clang-format 15 you can format control statements to always have braces. Also added linebreak at EOF because Windows doesn't do it for you.
Related commit:
9dc6b70f19Have you considered not using Windows?
i like working on a proper system thank you
t. windows user
t. fartix user
Please see the attached image for my reaction.
how dare you use a toy OS and make me cry 😭
t. windows user
4fe5676d63breaks pedantic but is necessary for correct functionality. @FMudanyali - please make a patch that both works correctly and is pedantic-compliant.